Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging refactoring #771

Merged
merged 9 commits into from
Oct 26, 2024
Merged

Logging refactoring #771

merged 9 commits into from
Oct 26, 2024

Conversation

mantzas
Copy link

@mantzas mantzas commented Oct 20, 2024

Which problem is this PR solving?

Resolves #155.

Short description of the changes

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 82.19178% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (3d3926e) to head (2700c55).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
observability/log/log.go 80.64% 4 Missing and 2 partials ⚠️
component/http/observability.go 73.33% 3 Missing and 1 partial ⚠️
observability/observability.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
- Coverage   83.61%   83.45%   -0.16%     
==========================================
  Files          65       65              
  Lines        3723     3766      +43     
==========================================
+ Hits         3113     3143      +30     
- Misses        483      492       +9     
- Partials      127      131       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mantzas mantzas marked this pull request as ready for review October 26, 2024 06:09
@mantzas mantzas merged commit f82d5c7 into master Oct 26, 2024
3 of 4 checks passed
@mantzas mantzas deleted the logging-refacotring branch October 26, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change log level at runtime
1 participant